http://gwt-code-reviews.appspot.com/341803/diff/26001/27009
File user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java
(right):

http://gwt-code-reviews.appspot.com/341803/diff/26001/27009#newcode65
user/src/com/google/gwt/logging/client/HasWidgetsLogHandler.java:65: if
(formatter instanceof HtmlLogFormatter) {
Add comment that we're trying to prevent HTML injection and that part of
the responsibility lies with the HtmlLogFormatter?

http://gwt-code-reviews.appspot.com/341803/diff/26001/27011
File user/src/com/google/gwt/logging/client/LogConfiguration.java
(right):

http://gwt-code-reviews.appspot.com/341803/diff/26001/27011#newcode53
user/src/com/google/gwt/logging/client/LogConfiguration.java:53: for
(Handler h : root.getHandlers()) {
Why do we need to remove handler? Can logging be initialized more than
once? Maybe add comment with explanation

http://gwt-code-reviews.appspot.com/341803/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to