http://gwt-code-reviews.appspot.com/719801/diff/1/12
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):
http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode62
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:62:
List<String> data = Lists.create();
On 2010/07/27 19:55:27, scottb wrote:
Might be slightly faster to initialize this in the ctor when you
actually have
the data available, as Lists.create(data).
Done.
http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode81
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:81:
for (int i = 0; i < data.length; i++) {
On 2010/07/27 19:55:27, scottb wrote:
This loop is just Lists.addAll(this.data, data)
Done.
http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode81
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:81:
for (int i = 0; i < data.length; i++) {
On 2010/07/27 20:21:12, conroy wrote:
On 2010/07/27 19:55:27, scottb wrote:
> This loop is just Lists.addAll(this.data, data)
yeah, should probably check that data.length % 2 == 0
I added assert()s
http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode234
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:234:
*/
On 2010/07/27 20:21:12, conroy wrote:
the comments here are now out of date since you no longer need to call
init()
before calling get().
You no longer need to, but maybe you should, since calling init() sets
the base time. I updated the javadoc to reflect that.
i think we should just adopt the On Demand Holder idiom here, with the
added
bonus that we can remove the synchronization overhead.
e.g:
private static class LazySpeedTracerLoggerHolder {
public static SpeedTracerLogger singeleton = new
SpeedTracerLogger();
}
public static SpeedTracerLogger get() {
return LazySpeedTracerLoggerHolder.singleton;
}
See:
http://www.cs.umd.edu/%7Epugh/java/memoryModel/DoubleCheckedLocking.html
http://www.cs.umd.edu/%7Epugh/java/memoryModel/jsr-133-faq.html
That is clever. Done.
http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode263
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:263:
SpeedTracerLogger(Writer writer) {
On 2010/07/27 20:21:12, conroy wrote:
note that this constructor is just for unit testing
Done. (local copy)
http://gwt-code-reviews.appspot.com/719801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
