The patch did not apply cleanly. I went through and tried to provide some feedback anyway.
http://gwt-code-reviews.appspot.com/893801/diff/16001/17001 File user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonProxyListRequest.java (right): http://gwt-code-reviews.appspot.com/893801/diff/16001/17001#newcode22 user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonProxyListRequest.java:22: import com.google.gwt.requestfactory.shared.SyncResult; SyncResult has been removed? http://gwt-code-reviews.appspot.com/893801/diff/16001/17001#newcode54 user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonProxyListRequest.java:54: public void handleResult(Object jsoResult, Set<SyncResult> syncResults) { 1.5-ism: @Override http://gwt-code-reviews.appspot.com/893801/diff/16001/17002 File user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonValueListRequest.java (right): http://gwt-code-reviews.appspot.com/893801/diff/16001/17002#newcode22 user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonValueListRequest.java:22: import com.google.gwt.requestfactory.shared.SyncResult; SyncResult was removed? http://gwt-code-reviews.appspot.com/893801/diff/16001/17003 File user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java (right): http://gwt-code-reviews.appspot.com/893801/diff/16001/17003#newcode197 user/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java:197: [email protected]::pushToValueStore(Ljava/lang/String;Lcom/google/gwt/core/client/JavaScriptObject;)(schemaAndId[2], jso); Was the change to '2' intentional here? http://gwt-code-reviews.appspot.com/893801/diff/16001/17006 File user/src/com/google/gwt/requestfactory/client/impl/JsoList.java (right): http://gwt-code-reviews.appspot.com/893801/diff/16001/17006#newcode217 user/src/com/google/gwt/requestfactory/client/impl/JsoList.java:217: return (T) rf.getValueStore().getRecordBySchemaAndId(rf.getSchema(key[2]), getRecordBySchemaAndId is not applicable for the arguments. Could it be because the patch did not apply cleanly? http://gwt-code-reviews.appspot.com/893801/diff/16001/17013 File user/src/com/google/gwt/requestfactory/shared/impl/CollectionProperty.java (right): http://gwt-code-reviews.appspot.com/893801/diff/16001/17013#newcode29 user/src/com/google/gwt/requestfactory/shared/impl/CollectionProperty.java:29: public class CollectionProperty<C extends Collection, E> extends Property<C> { Maybe add a comment that this handles Lists and Sets or is that a given? http://gwt-code-reviews.appspot.com/893801/diff/16001/17014 File user/src/com/google/gwt/requestfactory/shared/impl/TypeLibrary.java (right): http://gwt-code-reviews.appspot.com/893801/diff/16001/17014#newcode60 user/src/com/google/gwt/requestfactory/shared/impl/TypeLibrary.java:60: public static boolean isProxyType(Class<?> type) { Should this check for EntityProxy as a super type? http://gwt-code-reviews.appspot.com/893801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
