Bob noted a missing check for Set, which led me to realize that we had no Set equivalent of RecordListRequest/ProxyListRequest. The lastest patch adds it and fixes the nits.
http://gwt-code-reviews.appspot.com/893801/diff/23001/24007 File user/src/com/google/gwt/requestfactory/client/impl/JsoSet.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24007#newcode54 user/src/com/google/gwt/requestfactory/client/impl/JsoSet.java:54: return array; On 2010/09/20 17:31:18, bobv wrote:
Should this be list.asJso()?
Done. http://gwt-code-reviews.appspot.com/893801/diff/23001/24009 File user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24009#newcode147 user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java:147: if (type == List.class || type == Set.class) { On 2010/09/20 17:31:18, bobv wrote:
Could you add an assertion after this if block like:
assert !(type instanceof List || type instanceof Set)
So that if/when polymorphic collection types are added, this method
will make
its presence known?
Done. http://gwt-code-reviews.appspot.com/893801/diff/23001/24011 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24011#newcode448 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:448: propertyValue = getPropertyValueFromRequestCached(array, propertiesInProxy, i, On 2010/09/20 17:31:18, bobv wrote:
Formatting.
Done. http://gwt-code-reviews.appspot.com/893801/diff/23001/24011#newcode538 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:538: } else if (entityElement instanceof List) { On 2010/09/20 17:31:18, bobv wrote:
Set as well?
Good catch. I also had to update AbstractJsonProxyListRequest and RequestFactoryGenerator (only assumed Request methods can return List) http://gwt-code-reviews.appspot.com/893801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
