http://gwt-code-reviews.appspot.com/893801/diff/30001/31001 File user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonProxyCollectionRequest.java (right):
http://gwt-code-reviews.appspot.com/893801/diff/30001/31001#newcode69 user/src/com/google/gwt/requestfactory/client/impl/AbstractJsonProxyCollectionRequest.java:69: C proxies = createCollection(); Formatting. http://gwt-code-reviews.appspot.com/893801/diff/30001/31012 File user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java (right): http://gwt-code-reviews.appspot.com/893801/diff/30001/31012#newcode893 user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:893: if (retType.isAssignableTo(typeOracle.findType(List.class.getName())) Readability would be greatly improved by assigning these commonly-used JTypes to fields. http://gwt-code-reviews.appspot.com/893801/diff/30001/31012#newcode968 user/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java:968: superClass = AbstractJsonProxyListRequest.class; Move into the enum. http://gwt-code-reviews.appspot.com/893801/diff/30001/31019 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/893801/diff/30001/31019#newcode829 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:829: public void testPrimitiveList() { Where is the test for primitive sets? http://gwt-code-reviews.appspot.com/893801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
