LGTM
http://gwt-code-reviews.appspot.com/893801/diff/23001/24005 File user/src/com/google/gwt/requestfactory/client/impl/JsoCollection.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24005#newcode39 user/src/com/google/gwt/requestfactory/client/impl/JsoCollection.java:39: * @return Remove this blank @return http://gwt-code-reviews.appspot.com/893801/diff/23001/24007 File user/src/com/google/gwt/requestfactory/client/impl/JsoSet.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24007#newcode54 user/src/com/google/gwt/requestfactory/client/impl/JsoSet.java:54: return array; Should this be list.asJso()? http://gwt-code-reviews.appspot.com/893801/diff/23001/24009 File user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24009#newcode147 user/src/com/google/gwt/requestfactory/client/impl/ProxyJsoImpl.java:147: if (type == List.class || type == Set.class) { Could you add an assertion after this if block like: assert !(type instanceof List || type instanceof Set) So that if/when polymorphic collection types are added, this method will make its presence known? http://gwt-code-reviews.appspot.com/893801/diff/23001/24011 File user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24011#newcode448 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:448: propertyValue = getPropertyValueFromRequestCached(array, propertiesInProxy, i, Formatting. http://gwt-code-reviews.appspot.com/893801/diff/23001/24011#newcode538 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:538: } else if (entityElement instanceof List) { Set as well? http://gwt-code-reviews.appspot.com/893801/diff/23001/24016 File user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/893801/diff/23001/24016#newcode319 user/test/com/google/gwt/requestfactory/client/RequestFactoryTest.java:319: Whitespace. http://gwt-code-reviews.appspot.com/893801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
