http://gwt-code-reviews.appspot.com/1062801/diff/1/78
File
user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/78#newcode947
user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java:947:
"The domain type %s has more than one proxy type: %s and %s",
On 2010/10/29 14:38:04, tbroyer wrote:
Does it mean it's no longer a supported use case?

It just happened to me that if the goal is support for polymorphism (as
suggested by the javadoc on
SimpleRequestProcessor.ServiceLayer#getClientType), then maybe the
getClientType method should take a Class<?> argument that the returned
object should be assignable to; the domainToClientType would map a
domain class to a set of client types, and this check would only ensure
that there aren't two types in this set that have a hierarchical
relationship (one is a subclass of the other). Alternatively, that last
step would only issue a warning and only put in the set of client types
the most specific one.

That would cover the two use cases:
 - multiple views on a single object (mapping a domain class to multiple
client types), and
 - polymorphism (mapping from a domain class to a client type, and not
only the other way around as is done in 2.1.0)

I'll also note that the RequestSecurityProvider is gone without any
replacement (or I missed it), which leads to the question: how about the
use case that Stephen Haberman described in the above-linked Wave? is it
still supported? will it be? (if not in this patch but a future
iteration))

http://gwt-code-reviews.appspot.com/1062801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to