http://gwt-code-reviews.appspot.com/1062801/diff/1/18
File user/src/com/google/gwt/autobean/server/ProxyAutoBean.java (right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/18#newcode175
user/src/com/google/gwt/autobean/server/ProxyAutoBean.java:175: if
(visitor.visitValueProperty(name, value, x)) {
Why the empty then clause?

http://gwt-code-reviews.appspot.com/1062801/diff/1/18#newcode181
user/src/com/google/gwt/autobean/server/ProxyAutoBean.java:181: if
(value != null) {
bean != null, perhaps?

http://gwt-code-reviews.appspot.com/1062801/diff/1/19
File user/src/com/google/gwt/autobean/server/ShimHandler.java (right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/19#newcode78
user/src/com/google/gwt/autobean/server/ShimHandler.java:78:
method.setAccessible(true);
Why call method.setAccessible(true) twice?

http://gwt-code-reviews.appspot.com/1062801/diff/1/19#newcode83
user/src/com/google/gwt/autobean/server/ShimHandler.java:83: toReturn =
bean.get(name, toReturn);
This assignment to toReturn seems redundant

http://gwt-code-reviews.appspot.com/1062801/diff/1/24
File user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java (right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/24#newcode252
user/src/com/google/gwt/autobean/shared/AutoBeanCodex.java:252: * @param
bean
Remove the JavaDoc

http://gwt-code-reviews.appspot.com/1062801/diff/1/25
File user/src/com/google/gwt/autobean/shared/AutoBeanFactory.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/25#newcode46
user/src/com/google/gwt/autobean/shared/AutoBeanFactory.java:46: *
method's signature, save for the addition of a new initial paramater
that
paramater -> parameter

http://gwt-code-reviews.appspot.com/1062801/diff/1/25#newcode55
user/src/com/google/gwt/autobean/shared/AutoBeanFactory.java:55: * would
be paired with a category implemenation such as
implemenation -> implementation

http://gwt-code-reviews.appspot.com/1062801/diff/1/26
File user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java (right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/26#newcode128
user/src/com/google/gwt/autobean/shared/AutoBeanUtils.java:128: * {...@code
null} if the parameter is {...@code null}or not wrapped by an AutoBean.
null}or -> null} or

http://gwt-code-reviews.appspot.com/1062801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to