A few nits so far. Still reviewing.

http://gwt-code-reviews.appspot.com/1062801/diff/1/3
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/console/HttpClientTransport.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/3#newcode27
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/console/HttpClientTransport.java:27:

Eclipse .classpath now needs
GWT_TOOLS/lib/apache/http/httpclient-4.0.1.jar and
GWT_TOOLS/lib/apache/http/httpcore-4.0.1.jar

http://gwt-code-reviews.appspot.com/1062801/diff/1/17
File user/src/com/google/gwt/autobean/server/MapPropertyContext.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/17#newcode51
user/src/com/google/gwt/autobean/server/MapPropertyContext.java:51:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/17#newcode56
user/src/com/google/gwt/autobean/server/MapPropertyContext.java:56:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/17#newcode61
user/src/com/google/gwt/autobean/server/MapPropertyContext.java:61:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/17#newcode66
user/src/com/google/gwt/autobean/server/MapPropertyContext.java:66:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/31
File user/src/com/google/gwt/autobean/shared/impl/AbstractAutoBean.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/31#newcode115
user/src/com/google/gwt/autobean/shared/impl/AbstractAutoBean.java:115:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/33
File
user/src/com/google/gwt/autobean/shared/impl/StringEncodedAutoBean.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/33#newcode40
user/src/com/google/gwt/autobean/shared/impl/StringEncodedAutoBean.java:40:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/75
File
user/src/com/google/gwt/requestfactory/server/ReflectiveServiceLayer.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/75#newcode94
user/src/com/google/gwt/requestfactory/server/ReflectiveServiceLayer.java:94:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/89
File
user/src/com/google/gwt/requestfactory/server/testing/InProcessRequestContext.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/89#newcode40
user/src/com/google/gwt/requestfactory/server/testing/InProcessRequestContext.java:40:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/90
File
user/src/com/google/gwt/requestfactory/server/testing/InProcessRequestFactory.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/90#newcode46
user/src/com/google/gwt/requestfactory/server/testing/InProcessRequestFactory.java:46:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/91
File
user/src/com/google/gwt/requestfactory/server/testing/InProcessRequestTransport.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/91#newcode34
user/src/com/google/gwt/requestfactory/server/testing/InProcessRequestTransport.java:34:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/103
File
user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/103#newcode68
user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:68:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/103#newcode73
user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:73:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/103#newcode78
user/src/com/google/gwt/requestfactory/shared/impl/AbstractRequestContext.java:78:
@Override
1.6-ism

http://gwt-code-reviews.appspot.com/1062801/diff/1/128
File user/test/com/google/gwt/autobean/shared/AutoBeanCodexTest.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/128#newcode54
user/test/com/google/gwt/autobean/shared/AutoBeanCodexTest.java:54:
Checkstyle issue: extra newline

http://gwt-code-reviews.appspot.com/1062801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to