A possible infinite recursion and a few more minor nits.


http://gwt-code-reviews.appspot.com/1062801/diff/1/12
File user/src/com/google/gwt/autobean/server/AutoBeanFactoryMagic.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/12#newcode31
user/src/com/google/gwt/autobean/server/AutoBeanFactoryMagic.java:31: *
create a TypeOracle fram a ClassLoader prevents re-using the existing
model
fram -> from

http://gwt-code-reviews.appspot.com/1062801/diff/1/12#newcode74
user/src/com/google/gwt/autobean/server/AutoBeanFactoryMagic.java:74: *
Utility method to crete a new {...@link Proxy} instance.
crete -> create

http://gwt-code-reviews.appspot.com/1062801/diff/1/14
File user/src/com/google/gwt/autobean/server/Configuration.java (right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/14#newcode28
user/src/com/google/gwt/autobean/server/Configuration.java:28: * Used by
{...@link AutoBeanFactoryMagic#createBean()}.
JavaDocc style: {...@link AutoBeanFactoryMagic#createBean(Class,
Configuration)}

This is also used in ABF#create(Class).

Can you describe what is a Configuration for? Like "Stores the
categories non-wrapped methods of an AutoBean."

http://gwt-code-reviews.appspot.com/1062801/diff/1/15
File user/src/com/google/gwt/autobean/server/FactoryHandler.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/15#newcode33
user/src/com/google/gwt/autobean/server/FactoryHandler.java:33: * @param
categories the classes specified by a Category annotation
categories -> configuration

http://gwt-code-reviews.appspot.com/1062801/diff/1/31
File user/src/com/google/gwt/autobean/shared/impl/AbstractAutoBean.java
(right):

http://gwt-code-reviews.appspot.com/1062801/diff/1/31#newcode47
user/src/com/google/gwt/autobean/shared/impl/AbstractAutoBean.java:47:
protected static final Object[] EMPTY_OBJECT = new Object[0];
This seems unused, but very much similar to BeanMethod#EMPTY_OBJECT

http://gwt-code-reviews.appspot.com/1062801/diff/1/31#newcode89
user/src/com/google/gwt/autobean/shared/impl/AbstractAutoBean.java:89:
entry.setValue(auto.clone(true).as());
This seems to allow infinite recursion if there is a cycle in the
AutoBean relationships.

http://gwt-code-reviews.appspot.com/1062801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to