http://gwt-code-reviews.appspot.com/1310806/diff/1/3
File
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode841
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:841:
// instantiation during code generation would flag them for us.
This seems like it could result in looping through a long list of
"problems", and it's only done in DEBUG mode, perhaps we don't want to
descend into problems.report in less isLoggable(DEBUG)

http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode1134
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:1134:

This too seems like it could do unnecessary work in calling getArrayType
(which is a looping/recursive animal).

http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode1537
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:1537:
private void logReachableTypes(TreeLogger logger) {
So, in dev mode, we don't ever want to do this, even if log level is
DEBUG?

http://gwt-code-reviews.appspot.com/1310806/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to