http://gwt-code-reviews.appspot.com/1310806/diff/1/3 File user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java (right):
http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode841 user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:841: // instantiation during code generation would flag them for us. On 2011/02/04 23:01:37, jbrosenberg wrote:
This seems like it could result in looping through a long list of
"problems",
and it's only done in DEBUG mode, perhaps we don't want to descend
into
problems.report in less isLoggable(DEBUG)
I think most of the work is probably done in constructing the problems which unfortunately isn't easy to change based on the logging level. I went ahead and added an isLoggable test to ProblemReport.doReport anyway since it couldn't hurt. http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode1134 user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:1134: On 2011/02/04 23:01:37, jbrosenberg wrote:
This too seems like it could do unnecessary work in calling
getArrayType (which
is a looping/recursive animal).
Good idea. http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode1537 user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:1537: private void logReachableTypes(TreeLogger logger) { On 2011/02/04 23:01:37, jbrosenberg wrote:
So, in dev mode, we don't ever want to do this, even if log level is
DEBUG? I think you read this wrong. It's "skip if dev_mode and can't log debug" http://gwt-code-reviews.appspot.com/1310806/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
