[gwt-contrib] Re: Reduce logging work in STOB. Wrap logging calls with isLoggable and only create .rpc.log during ... (issue1310806)

[tobyr]

http://gwt-code-reviews.appspot.com/1310806/diff/1/3
File
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode1537
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:1537:
private void logReachableTypes(TreeLogger logger) {
On 2011/02/05 00:01:58, jbrosenberg wrote:

Oops...Yeah, so...inProdMode, we always don't skip, even if logLevel

is not

DEBUG?  I guess I'm not sure why we don't just have the check be only

for DEBUG,

and not care about isProdMode?

I think it's nice to be able to get the .rpc.log without having to
perform a webmode compile. Basing it on logging at DEBUG level seemed
reasonable.

http://gwt-code-reviews.appspot.com/1310806/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors