LGTM (with one minor question remaining)

http://gwt-code-reviews.appspot.com/1310806/diff/1/3
File
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1310806/diff/1/3#newcode1537
user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:1537:
private void logReachableTypes(TreeLogger logger) {
Oops...Yeah, so...inProdMode, we always don't skip, even if logLevel is
not DEBUG?  I guess I'm not sure why we don't just have the check be
only for DEBUG, and not care about isProdMode?

http://gwt-code-reviews.appspot.com/1310806/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to