On Thu, Mar 3, 2011 at 3:27 PM, <[email protected]> wrote:
This works out great for TypeOracleMediatorFromByteCodeTest, but when
we
compile from source in TypeOracleMediatorFromSourceTest, the place we
need to get in to modify the Type Oracle instance is nested inside of
CompilationState which is also nested inside of
CompilationStateBuilder.
 That means disruption to these other two classes.  Seems like the
test
would be even more intrusive if I did that - what do you think?

I have a solution for you!

In TypeOracleMediatorFromSourceTest.buildTypeOracle(), you have a chance
to mess with the type oracle before you run the checks.  So here is
where you'd inject your call to
typeOracle.setupHackyAlternateJsoClassForTesting(...).

Have the implementation of setupHackyAlternateJsoClassForTesting() do a
jsoSingleImpls.clear(), computeSingleJsoImplData(allTypes.values()).

http://gwt-code-reviews.appspot.com/1369805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to