Scott suggested moving these tests to JSORestrictionsTest, which is not
just the right place, but by only testing from source, it side-steps the
JavaScriptObject bytecode issue that was causing such a huge pain.


http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/src/com/google/gwt/dev/javac/BytecodeSignatureMaker.java
File dev/core/src/com/google/gwt/dev/javac/BytecodeSignatureMaker.java
(right):

http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/src/com/google/gwt/dev/javac/BytecodeSignatureMaker.java#newcode193
dev/core/src/com/google/gwt/dev/javac/BytecodeSignatureMaker.java:193:
CompileDependencyVisitor v =
visitCompileDependenciesInBytecode(byteCode);
ooh, I couldn't resist this little refactor when I happened to glance at
this code.

http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java
File dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java
(right):

http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode34
dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:34: /*
updated as per scottb's OOB suggestion

http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode249
dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:249:
removed locally

http://gwt-code-reviews.appspot.com/1369805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to