LGTM w/ nits. I think this is actually much better than the first formulation, and has the added benefit of testing JsoRestrictionsChecker directly.
http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java File dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java (right): http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode34 dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:34: /* LG, but it might be better to move this to JavaCompilationSuite since most of the tests in that suite have the same issue. http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode96 dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:96: System.err.print(goodCode.toString()); Debug statement http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode193 dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:193: .append(" public static class CommonBase extends JavaScriptObject implements CommonInterface {\n"); Style nit: probably better to break the string literals sooner than have to break the outer formatting. http://gwt-code-reviews.appspot.com/1369805/diff/1013/dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java#newcode207 dev/core/test/com/google/gwt/dev/javac/JSORestrictionsTest.java:207: System.err.print(goodCode.toString()); Debug statement http://gwt-code-reviews.appspot.com/1369805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
