http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java File user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java (right):
http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java#newcode617 user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:617: } Extra whitespace. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java#newcode742 user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:742: private final Shared.SerializeFinalFieldsOptions shouldSerializeFinalFields; Sort fields alphabetically unless they have an initialization dependency. While you're at it, remove the blank lines within the field declarations. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/Shared.java File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode56 user/src/com/google/gwt/user/rebind/rpc/Shared.java:56: private static SerializeFinalFieldsOptions serializeFinalFieldsValue; Don't store this in a static field, since it's dependent on the values of a PropertyOracle. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java File user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java#newcode279 user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java:279: static boolean isNotStaticTransientOrFinal(Field field) { Is this method still used? http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java#newcode686 user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java:686: && !Modifier.isPublic(declField.getModifiers())) || Modifier.isFinal(declField.getModifiers()); Double-check formatting here. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/RPCFinalFieldsTest.gwt.xml File user/test/com/google/gwt/user/RPCFinalFieldsTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/RPCFinalFieldsTest.gwt.xml#newcode20 user/test/com/google/gwt/user/RPCFinalFieldsTest.gwt.xml:20: <set-property name='rpc.enforceTypeVersioning' value='true' /> What is this property for? http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java#newcode22 user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java:22: Extra blank lines here and in other test code. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java#newcode33 user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java:33: FinalFieldsNode node = new FinalFieldsNode(); Is there a test anywhere of final field values being sent from the client? This test uses the default constructor, which is also called by the server code. Instead, shouldn't this pass non-default values to the three-arg constructor to verify that the server code properly resets final values? http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
