http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right):
http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode56 user/src/com/google/gwt/user/rebind/rpc/Shared.java:56: private static SerializeFinalFieldsOptions serializeFinalFieldsValue; See comment in previous revision. Static fields in Generator types can cause flaky behavior. http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode100 user/src/com/google/gwt/user/rebind/rpc/Shared.java:100: propertyOracle, RPC_PROP_SERIALIZE_FINAL_FIELDS, "FALSE").toUpperCase(); You can use Enum.valueOf() instead of the if block below. http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java#newcode56 user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java:56: private FinalFieldsTestServiceAsync finalFieldsTestService; Member sort order. Fields should be defined before methods. http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java#newcode27 user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java:27: public class FinalFieldsNode implements IsSerializable { Use Serializable instead of IsSerializable. http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/server/rpc/FinalFieldsTestServiceImpl.java File user/test/com/google/gwt/user/server/rpc/FinalFieldsTestServiceImpl.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/server/rpc/FinalFieldsTestServiceImpl.java#newcode28 user/test/com/google/gwt/user/server/rpc/FinalFieldsTestServiceImpl.java:28: public FinalFieldsNode transferObject(FinalFieldsNode node) { Check the incoming values in node to make sure that final fields are being set properly when sent by the client. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
