http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java File user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java (right):
http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java#newcode617 user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:617: } On 2011/04/13 23:32:33, bobv wrote:
Extra whitespace.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java#newcode742 user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java:742: private final Shared.SerializeFinalFieldsOptions shouldSerializeFinalFields; On 2011/04/13 23:32:33, bobv wrote:
Sort fields alphabetically unless they have an initialization
dependency. While
you're at it, remove the blank lines within the field declarations.
It seems that shouldSerializeFinalFields variable is never used. I removed it. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/Shared.java File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode56 user/src/com/google/gwt/user/rebind/rpc/Shared.java:56: private static SerializeFinalFieldsOptions serializeFinalFieldsValue; On 2011/04/13 23:32:33, bobv wrote:
Don't store this in a static field, since it's dependent on the values
of a
PropertyOracle.
Since it is from the xml property, I think it should be fine to use a static field? It should be similar to the above field "gwt.supressNonStaticFinalFieldWarnings". http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java File user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java#newcode279 user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java:279: static boolean isNotStaticTransientOrFinal(Field field) { On 2011/04/13 23:32:33, bobv wrote:
Is this method still used?
Not used any more. Removed. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java#newcode686 user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java:686: && !Modifier.isPublic(declField.getModifiers())) || Modifier.isFinal(declField.getModifiers()); On 2011/04/13 23:32:33, bobv wrote:
Double-check formatting here.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/RPCFinalFieldsTest.gwt.xml File user/test/com/google/gwt/user/RPCFinalFieldsTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/RPCFinalFieldsTest.gwt.xml#newcode20 user/test/com/google/gwt/user/RPCFinalFieldsTest.gwt.xml:20: <set-property name='rpc.enforceTypeVersioning' value='true' /> On 2011/04/13 23:32:33, bobv wrote:
What is this property for?
Unrelated. Removed. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java#newcode22 user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java:22: On 2011/04/13 23:32:33, bobv wrote:
Extra blank lines here and in other test code.
Done. http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java#newcode33 user/test/com/google/gwt/user/client/rpc/FinalFieldsTest.java:33: FinalFieldsNode node = new FinalFieldsNode(); On 2011/04/13 23:32:33, bobv wrote:
Is there a test anywhere of final field values being sent from the
client? This
test uses the default constructor, which is also called by the server
code.
Instead, shouldn't this pass non-default values to the three-arg
constructor to
verify that the server code properly resets final values?
I changed the constructor. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
