Can you briefly describe the reason for this change? If I understand correctly, the change is to extend handling of compile time constants to Strings as well as base types?
http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java File dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java (right): http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java#newcode573 dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java:573: This same logic seems to be repeated in each file in this patch. Can it be made into a shared utility method somewhere? http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java#newcode574 dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java:574: boolean isCompileTimeConstant = extra parens in "(binding.isFinal())" http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right): http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2971 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2971: boolean isCompileTimeConstant = extra parens in "(binding.isFinal())" http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java File dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java (right): http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java#newcode245 dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java:245: boolean isCompileTimeConstant = extra parens in "(binding.isFinal())" http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java#newcode246 dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java:246: binding.isStatic() && (binding.isFinal()) && (binding.constant() != Constant.NotAConstant); why no assert here (you have it in similar places elsewhere)? http://gwt-code-reviews.appspot.com/1449818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
