Yes, according to the JLS, Strings are considered compiled time constants, but we've been doing this wrong up to now. (Not that it mattered before now.)
http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java File dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java (right): http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java#newcode573 dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java:573: This copy will get deleted soon, but the problem is getting a reference to java.lang.String. I'll see what I can do. http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java#newcode574 dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java:574: boolean isCompileTimeConstant = On 2011/06/14 23:46:25, jbrosenberg wrote:
extra parens in "(binding.isFinal())"
Done. http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right): http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2971 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2971: boolean isCompileTimeConstant = On 2011/06/14 23:46:25, jbrosenberg wrote:
extra parens in "(binding.isFinal())"
Done. http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java File dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java (right): http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java#newcode245 dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java:245: boolean isCompileTimeConstant = On 2011/06/14 23:46:25, jbrosenberg wrote:
extra parens in "(binding.isFinal())"
Done. http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java#newcode246 dev/core/src/com/google/gwt/dev/jjs/impl/ReferenceMapper.java:246: binding.isStatic() && (binding.isFinal()) && (binding.constant() != Constant.NotAConstant); Can't get a reference to java.lang.String from here; but I'll see what I can do. http://gwt-code-reviews.appspot.com/1449818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
