LGTM w/a couple questions
http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right): http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2837 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2837: private static boolean isCompileTimeConstant(FieldBinding binding) { I don't think it's legal/syntactically possible for a java field to be both final and volatile, which would make this assertion tautologically true, no? http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2840 dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2840: binding.isStatic() && binding.isFinal() && (binding.constant() != Constant.NotAConstant); should this if test live inside the assert, maybe as a conditional, so the if test doesn't get evaluated if assertions not enabled? http://gwt-code-reviews.appspot.com/1449818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
