http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
(right):

http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2837
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2837:
private static boolean isCompileTimeConstant(FieldBinding binding) {
You would think, yep.  It's just an assertion check on the fact that we
don't model final and volatile independently.  We use a single enum
value for either.

http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java#newcode2840
dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java:2840:
binding.isStatic() && binding.isFinal() && (binding.constant() !=
Constant.NotAConstant);
Doesn't matter, in byte code, the check for assertions being enabled is
itself an if test that is slower (as written) than the local variable
check.  If byte code optimizers are running, it should remove this
entirely.

http://gwt-code-reviews.appspot.com/1449818/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to