Brian Slesinsky has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
......................................................................
Patch Set 1: Code-Review+1
(4 comments)
....................................................
File dev/core/src/com/google/gwt/core/ext/typeinfo/JParameterizedType.java
Line 37: * Returns whether the parametrized type has any wildcards.
Perhaps add some examples of types with wildcards?
Line 39: * @return {@code true} if wildcards are present, {@code false}
otherwise.
This line seems redundant; instead you could change the first line
to "Returns true if ..."
....................................................
File dev/core/src/com/google/gwt/dev/javac/typemodel/JParameterizedType.java
Line 336: * @return {@code true} if wildcards are present, {@code false}
otherwise.
I think we can skip the javadoc here since it's on the interface.
....................................................
File user/src/com/google/gwt/uibinder/rebind/HandlerEvaluator.java
Line 204: String handlerSourceName =
Maybe we should have a test somewhere in GWT that anonymous handlers work?
--
To view, visit https://gwt-review.googlesource.com/2470
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcd6ecec455512a7da5eb473c6bf2e9f402f0ea
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
