Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
......................................................................
Patch Set 3:
(3 comments)
....................................................
File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
Line 229: void onWildcaredValueChangeList(ValueChangeEvent<List<?>>
event) {
What I meant before was the API is:
addXXX(ValueChangeEvent<List<?>>)
in this case the API is still:
addXXX(ValueChangeEvent<?>)
Actually, it is interesting to me that this is working right now :)
....................................................
File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.ui.xml
Line 698: <img src="{values.aUrl}" ui:field='myImage'/>
Pls remove extra space added.
....................................................
File
user/test/com/google/gwt/uibinder/test/client/WildcardValueChangeWidget.java
Line 40: * Here is the key for the test. ValueChangeHandler is
parameterized by ? and not <T>q
<T>q --> <T>.
--
To view, visit https://gwt-review.googlesource.com/2470
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcd6ecec455512a7da5eb473c6bf2e9f402f0ea
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
