Roberto Lublinerman has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
......................................................................
Patch Set 2:
(8 comments)
....................................................
File user/test/com/google/gwt/uibinder/test/client/BadValueChangeWidget.java
Line 37: HasChangeHandlers, HasName {
Will remove those
Line 64: public HandlerRegistration
addValueChangeHandler(ValueChangeHandler<?> handler) {
Done
Line 96: protected void onLoad() {
Done
....................................................
File user/test/com/google/gwt/uibinder/test/client/UiHandlerTest.java
Line 23: * TODO(rluble); add more relevant tests.
Done
Line 28: private com.google.gwt.user.client.ui.DockPanel root;
Nope. Just copied the code from UiBinderTest. Will fix
....................................................
File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
Line 202: @UiField(provided = true) BadValueChangeWidget
myBadValueChangeWidget =
Done
Line 212: this.event = event;
Done
Line 220:
Not sure, but I'll add the test.
--
To view, visit https://gwt-review.googlesource.com/2470
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcd6ecec455512a7da5eb473c6bf2e9f402f0ea
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
