Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
......................................................................
Patch Set 2:
(9 comments)
....................................................
Commit Message
Line 11: in their type parameters.
I wonder if diamond operator would have helped with any of these issues?
....................................................
File user/test/com/google/gwt/uibinder/test/client/BadValueChangeWidget.java
Line 37: HasChangeHandlers, HasName {
Is there any reason to need for HasName and HasChangeHandlers?
Line 64: public HandlerRegistration
addValueChangeHandler(ValueChangeHandler<?> handler) {
I'm little bit lost in this class. If I'm not missing anything, we can
replace handler related stuff in this class with following:
HandlerRegistration addValueChangeHandler(ValueChangeHandler<?> handler) {
return addHandler(handler, ValueChangeEvent.getType());
}
public void setValue(String value) {
String oldValue = getValue();
myValue = value;
fireEvent(new ValueChangeEvent<?>(value) { });
}
Line 96: protected void onLoad() {
remove?
....................................................
File user/test/com/google/gwt/uibinder/test/client/UiHandlerTest.java
Line 23: * TODO(rluble); add more relevant tests.
; -> :
=)
Line 28: private com.google.gwt.user.client.ui.DockPanel root;
nit: Any reasons to not import?
....................................................
File user/test/com/google/gwt/uibinder/test/client/WidgetBasedUi.java
Line 202: @UiField(provided = true) BadValueChangeWidget
myBadValueChangeWidget =
Perhaps
BadValueChangeWidget -> WildcardValueWidget
myBadValueChange -> myWildcardValueWidget
Line 212: this.event = event;
Perhaps valueChangeEvent and wildcardValueChangeEvent?
Line 220:
I can't remember exactly but should we also have a test scenario like
ValueChangeEvent<K<?>>?
--
To view, visit https://gwt-review.googlesource.com/2470
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbcd6ecec455512a7da5eb473c6bf2e9f402f0ea
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Roberto Lublinerman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
