Goktug Gokdogan has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
......................................................................
Patch Set 5:
@Thomas: I don't think it is ideal but also I dont think it would cause any
errors.
The previous approach was already leaking com.google.gwt.core.client.impl
to server side for de-serialization and the code was actually executed.
This one only uses it for instanceof check on a code path that is not
executed on server-side (guarded by GWT.isScript) and also in practice it
works - at least in our side.
Did you hit any issue related to this?
@John: This class is used in DTOs shared by client and server. Why do you
think it shouldn't be in shared?
--
To view, visit https://gwt-review.googlesource.com/2160
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98ae52858d87b6ac4a0c844464b25540be454942
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
