Goktug Gokdogan has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
......................................................................
Patch Set 5:
(1 comment)
I think there are 2 misunderstandings:
1. This is not introducing a new one - replacing a previous one. Old code
was already depending on SerializableThrowable which used to be in client
package.
2. I'm not against dropping the dependency.
....................................................
File user/src/com/google/gwt/core/shared/SerializableThrowable.java
Line 150: } catch (JavaScriptException e) {
This code is guarded by GWT.isScript; never executed in server.
--
To view, visit https://gwt-review.googlesource.com/2160
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98ae52858d87b6ac4a0c844464b25540be454942
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
