Goktug Gokdogan has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
......................................................................
Patch Set 5:
FYI, if we are putting a hard rule on this, according to our internal build
file following classes are also in this category:
# Despite the "client" designation, these packages are
# also reached by server RPC code:
"svn/trunk/user/src/com/google/gwt/canvas/dom/client/*.java",
"svn/trunk/user/src/com/google/gwt/debug/client/DebugInfo.java",
"svn/trunk/user/src/com/google/gwt/media/dom/client/*.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/core/**/*CustomFieldSerializer*.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/core/java/util/*.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/SerializedTypeViolationException.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/IncompatibleRemoteServiceException.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/IsSerializable.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/GwtTransient.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/RemoteService.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/AsyncCallback.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/RemoteServiceRelativePath.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/RpcToken.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/RpcTokenException.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/RpcTokenExceptionHandler.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/impl/AbstractSerialization*.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/RpcRequestBuilder.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/InvocationException.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/CustomFieldSerializer.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/XsrfProtectedService.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/XsrfToken.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/XsrfTokenService.java",
"svn/trunk/user/src/com/google/gwt/http/client/RequestBuilder.java",
"svn/trunk/user/src/com/google/gwt/http/client/Request.java",
"svn/trunk/user/src/com/google/gwt/http/client/Header.java",
"svn/trunk/user/src/com/google/gwt/http/client/Response.java",
"svn/trunk/user/src/com/google/gwt/http/client/ResponseImpl.java",
"svn/trunk/user/src/com/google/gwt/http/client/RequestException.java",
"svn/trunk/user/src/com/google/gwt/http/client/RequestPermissionException.java",
"svn/trunk/user/src/com/google/gwt/http/client/RequestTimeoutException.java",
"svn/trunk/user/src/com/google/gwt/http/client/RequestCallback.java",
"svn/trunk/user/src/com/google/gwt/http/client/StringValidator.java",
"svn/trunk/user/src/com/google/gwt/http/client/URL.java",
"svn/trunk/user/src/com/google/gwt/http/client/UrlBuilder.java",
"svn/trunk/user/src/com/google/gwt/json/client/JSONArray.java",
"svn/trunk/user/src/com/google/gwt/json/client/JSONBoolean.java",
"svn/trunk/user/src/com/google/gwt/json/client/JSONException.java",
"svn/trunk/user/src/com/google/gwt/json/client/JSONNull.java",
"svn/trunk/user/src/com/google/gwt/json/client/JSONNumber.java",
"svn/trunk/user/src/com/google/gwt/json/client/JSONObject.java",
"svn/trunk/user/src/com/google/gwt/json/client/JSONString.java",
"svn/trunk/user/src/com/google/gwt/json/client/JSONValue.java",
"svn/trunk/user/src/com/google/gwt/core/client/impl/SerializableThrowable.java",
"svn/trunk/user/src/com/google/gwt/core/client/JsonUtils.java",
"svn/trunk/user/src/com/google/gwt/core/client/impl/WeakMapping.java",
"svn/trunk/user/src/com/google/gwt/xhr/client/ReadyStateChangeHandler.java",
"svn/trunk/user/src/com/google/gwt/xhr/client/XMLHttpRequest.java",
"svn/trunk/user/src/com/google/gwt/user/client/Timer.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/SerializationException.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/SerializationStreamReader.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/SerializationStreamWriter.java",
"svn/trunk/user/src/com/google/gwt/rpc/client/ast/*.java",
"svn/trunk/user/src/com/google/gwt/rpc/client/impl/CommandSerializationStreamWriterBase.java",
"svn/trunk/user/src/com/google/gwt/rpc/client/impl/CommandClientSerializationStreamReader.java",
"svn/trunk/user/src/com/google/gwt/rpc/client/impl/EscapeUtil.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java",
"svn/trunk/user/src/com/google/gwt/user/client/rpc/impl/Serializer.java",
"svn/trunk/user/src/com/google/gwt/rpc/client/impl/HasValuesCommandSink.java",
"svn/trunk/user/src/com/google/gwt/rpc/client/impl/SimplePayloadSink.java",
"svn/trunk/user/src/com/google/gwt/rpc/client/impl/RemoteException.java",
# ...which need:
"svn/trunk/user/src/com/google/gwt/core/client/GWT.java",
"svn/trunk/user/src/com/google/gwt/core/client/JavaScriptException.java",
"svn/trunk/user/src/com/google/gwt/core/client/JavaScriptObject.java",
"svn/trunk/user/src/com/google/gwt/core/client/JsArray.java",
"svn/trunk/user/src/com/google/gwt/core/client/Duration.java",
"svn/trunk/user/src/com/google/gwt/core/client/Scheduler.java",
"svn/trunk/user/src/com/google/gwt/user/client/Window.java",
"svn/trunk/user/src/com/google/gwt/user/client/Window*.java",
"svn/trunk/user/src/com/google/gwt/user/client/BaseListenerWrapper.java",
"svn/trunk/user/src/com/google/gwt/user/client/Element.java",
"svn/trunk/user/src/com/google/gwt/user/client/Event.java",
"svn/trunk/user/src/com/google/gwt/user/client/EventListener.java",
"svn/trunk/user/src/com/google/gwt/user/client/EventPreview.java",
"svn/trunk/user/src/com/google/gwt/user/client/NativePreviewEvent.java",
"svn/trunk/user/src/com/google/gwt/user/client/History.java",
"svn/trunk/user/src/com/google/gwt/user/client/impl/HistoryImpl.java",
"svn/trunk/user/src/com/google/gwt/user/client/impl/DomImpl.java",
"svn/trunk/user/src/com/google/gwt/user/client/HistoryListener.java",
"svn/trunk/user/src/com/google/gwt/user/client/Cookies.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/AcceptsOneWidget.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/Widget.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/IsWidget.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/HasOneWidget.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/HasVisibility.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/HasWidgets.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/HasText.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/AbsolutePanel.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/ComplexPanel.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/IndexedPanel.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/InsertPanel.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/Panel.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/AttachDetachException.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/UIObject.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/PotentialElement.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/RootPanel.java",
"svn/trunk/user/src/com/google/gwt/user/client/ui/WidgetCollection.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/HasNativeEvent.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/PrivateMap.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/DomEvent.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/KeyEvent.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/KeyCodeEvent.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/KeyCodes.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/KeyUpEvent.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/HasKeyUpHandlers.java",
"svn/trunk/user/src/com/google/gwt/event/dom/client/KeyUpHandler.java",
"svn/trunk/user/src/com/google/gwt/user/client/DOM.java",
"svn/trunk/user/src/com/google/gwt/user/client/impl/DOMImpl.java",
"svn/trunk/user/src/com/google/gwt/user/client/impl/WindowImpl.java",
"svn/trunk/user/src/com/google/gwt/dom/client/*.java",
"svn/trunk/user/src/com/google/gwt/core/client/impl/Impl.java",
"svn/trunk/user/src/com/google/gwt/core/client/impl/Disposable.java",
"svn/trunk/user/src/com/google/gwt/core/client/impl/UnloadSupport.java",
"svn/trunk/user/src/com/google/gwt/core/client/impl/StackTraceCreator.java",
"svn/trunk/user/src/com/google/gwt/core/client/impl/SchedulerImpl.java",
"svn/trunk/user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java",
"svn/trunk/user/src/com/google/gwt/core/client/JsArrayInteger.java",
"svn/trunk/user/src/com/google/gwt/core/client/JsArrayString.java",
"svn/trunk/user/src/com/google/gwt/core/client/RunAsyncCallback.java",
"svn/trunk/user/src/com/google/gwt/i18n/client/constants/*.java",
"svn/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/*.java",
"svn/trunk/user/src/com/google/gwt/i18n/client/impl/plurals/*.java",
"svn/trunk/user/src/com/google/gwt/i18n/client/impl/*.java",
"svn/trunk/user/src/com/google/gwt/i18n/client/*.java",
"svn/trunk/user/src/com/google/gwt/i18n/rebind/keygen/*.java",
# And it's also sensible to want for serialization:
"svn/trunk/user/src/com/google/gwt/user/client/ui/SuggestOracle.java",
--
To view, visit https://gwt-review.googlesource.com/2160
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98ae52858d87b6ac4a0c844464b25540be454942
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
