Thomas Broyer has posted comments on this change.
Change subject: Introduces a common SerializableThrowable as public API.
......................................................................
Patch Set 5:
(1 comment)
@Goktug: I was trying to move isClassMetadataAvailable and
resolveDesignatedType into a SerializableThrowableHelper class with a
super-sourced version ('JRE' version would return true unconditionally and
would throw, respectively), but I ran into weird IllegalAccessError. So
let's just remove the JavaScriptException case if you think it's OK.
....................................................
File user/src/com/google/gwt/core/shared/SerializableThrowable.java
Line 150: } catch (JavaScriptException e) {
This code won't run on the server-side (it's guarded by isScript, via
isClassMetadataAvailable), so most JVMs (OpenJDK and Oracle JDK at least)
won't load the class.
--
To view, visit https://gwt-review.googlesource.com/2160
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98ae52858d87b6ac4a0c844464b25540be454942
Gerrit-PatchSet: 5
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
