SGTM
On Tue, May 13, 2014 at 4:26 AM, Julien Dramaix <[email protected]>wrote: > >>> Others: > >>> - Clicking images shows blank page - perhaps just a deployment issue > >> > >> > >> Don't see this issue, what images do you mean? > >> > > > > Click devmode screenshot in > http://gwtproject.gquery.org/gettingstarted.html > > This issue already exists in the production website. I created a bug to > track it and I propose to fix it later in another patch : > https://code.google.com/p/google-web-toolkit/issues/detail?id=8707 > > > So I think we should either keep the old behavior (i.e. auto-collapse) > or move the new behavior (no content association for ALL parent menus, > expand and collapse on click, NO auto-collapse). > > Again the second option is ideal from my point of view but we may want > to do it later for reducing the amount work. > > I'm more in favor of the second option also. > > > > I know this is not a regression - as I noted earlier, all of my comments > on the second part are already existing problems. The code examples was > broken when we moved to gwtproject.org. > > - We don't have syntax highlighting for example code (you can see that > in the pages that you have linked) > > - Content is not formatted at all in some sample codes (see > http://gwtproject.gquery.org/doc/latest/tutorial/JUnit.html#write) - I > guess I only saw a few of them. > > > We can defer all these stuff, just pointed in case if they are easy to > fix. > > Indeed we should defer these stuff. During the gwt-meetup, I would like to > propose and discuss of a possible revamp of the website. During this > revamp, we could fixe all these problems. > > I propose that Manolo (thanks again for the good job) fixes the behavior > of the menu according to the Goktug second option and then merge his > patches in order that we can deploy this version in production. This > version improves a lot the existing web site and I would like to add a > search box (using google custom search) asap. > > Julien > > > On Mon, May 12, 2014 at 9:54 PM, 'Goktug Gokdogan' via GWT Contributors < > [email protected]> wrote: > >> >> >> On Sat, May 10, 2014 at 8:02 AM, Manuel Carrasco Moñino < >> [email protected]> wrote: >> >>> >>> >>> >>> On Sat, May 10, 2014 at 2:33 AM, 'Goktug Gokdogan' via GWT Contributors >>> <[email protected]> wrote: >>> >>>> Pretty cool. Thanks for all the work. Also special kudos for fixing the >>>> styling for download page, it is much more elegant now! >>>> >>>> Footer: >>>> - We are now missing the extra space in the bottom of the pages (the >>>> one before the footer) >>>> >>> >>> done >>> >>> - The area for the footer is larger and the text is closer to the >>>> bottom - I think the original spacing was better. Also if you take a look >>>> at the overview page you will see the footer hides part of the image. >>>> >>> >>> fixed css >>> >>> >>>> >>>> Others: >>>> - Clicking images shows blank page - perhaps just a deployment issue >>>> >>> >>> Don't see this issue, what images do you mean? >>> >>> >> >> Click devmode screenshot in >> http://gwtproject.gquery.org/gettingstarted.html >> >> >>> - There is a broken "Advanced Topics" menu item - I think it is mixed >>>> up with the Logging menu item. >>>> >>> >>> Fixed, the logging item was indented wrong >>> >>> >>>> - I would put "Optimize" to Advanced topics. Perhaps security and >>>> i18n as well. >>>> >>> >>> Done, I think i18n could be out. But anyway is difficult to put the edge >>> about what are or not advanced topics >>> >>> >>>> - Perhaps move Community -> Developer Spotlight under Resources? >>>> >>> >>> done >>> >>> - In Resources, we can move gwt surveys to the end of the list >>>> >>> >>> done >>> >>> >>>> >>>> Below are other issues that doesn't look like regressions. Perhaps we >>>> can have some other quick wins before publishing the final version? >>>> >>>> Menu: >>>> - Ideally the arrows shouldn't indent the menu items and instead menu >>>> items should be aligned by text (e.g. gmail). I'm not sure if you are >>>> reusing any widgets here; if you aren't reusing we might want to change >>>> that. >>>> >>> >>> done. We dont use any widget, just html+css. gquery enhances the list >>> adding handlers using selectors. >>> >>> >>>> - We might want to change how menus behave. I actually like GWT >>>> Developer pages (e.g. https://developers.google.com/appengine/pricing) >>>> where menu items that are parents of the other menu items are not used as >>>> links to a content, instead they serve as a placeholder and >>>> collapses/expands based when clicked. Also it won't auto collapse existing >>>> items. I think all together that is more useable. >>>> >>> >>> I have changed parents with not content (href = #) to expand/collapse >>> menu (See 'Advance topics' in docs). >>> >>> Having parent-items with content makes the menu shorter and easy to use, >>> like 'side bars' in google code wikis >>> https://code.google.com/p/support/wiki/WikiSyntax#Side_navigation >>> >>> I'd rather auto-collapse on, but I have set it off as you prefer. >>> >>> >> >> Even if you look at the menu in that wiki page, you will see that parent >> menu items are not acting as links to their own content instead they are >> just placeholders for grouping and will collapse/expand on click. I think >> that is the most intuitive and what we should do in the long run, however >> that might require some work to move the content to child pages. >> >> Nevertheless I think the last version is problematic: >> - Having menu item sometimes collapse sometimes not collapse when >> clicked is not user friendly as they will behave inconsistently. >> - As it is difficult and not easy to discover how to collapse a menu >> with content after it is expanded, it can become annoying for users to not >> have auto-collapse enabled on navigation. >> >> So I think we should either keep the old behavior (i.e. auto-collapse) or >> move the new behavior (no content association for ALL parent menus, expand >> and collapse on click, NO auto-collapse). >> Again the second option is ideal from my point of view but we may want to >> do it later for reducing the amount work. >> >> >> >>> >>>> General: >>>> - We have smaller size font for links (probably regular text font is >>>> larger than it suppose to be). >>>> >>> >>> Fixed >>> >>> >>>> - Looks like you made the body wider which I think is good but making >>>> the whole page right aligned (i.e. all extra space goes to left) is not a >>>> good idea. It looks really bad in widescreen (which many developers has). >>>> We should probably follow a different approach for distributing the space >>>> (e.g. add the extra space to left until a max value is reached). >>>> >>> >>> I dont know if I understand correctly. The width is adjusted based on >>> media sizes, and I have set 3 sizes: wide desktop, small desktop & tablets >>> and mobile. Also I have changed the font size (16 -> 14px) so as there is >>> more text in the same place, and text alignment (left -> justify). >>> >>> I have adjusted content padding for big desktop, I see correctly the >>> pages, let me know if that works for you. >>> >> >> LGTM. It looks like it distributes the spacing evenly for left and right >> sight. I would use less padding before the leftnav but this is mostly ok. >> >> I'm not sure if this is a new problem or not but now when you switch >> through menu items, left nav sometimes jumps around. It looks this is >> related to scrollbar being shown on the right or not. Perhaps you can use >> the scrollbar only for the content bar to prevent that from happening. >> >> >>> >>> >>>> - All code samples lost formatting and even some lost line wrapping >>>> after site migration. >>>> >>> >>> Code styling has not changed for code blocks, I see these pages (current >>> site, demo site) in the same way, maybe there is some other page wrong or >>> some style interfering >>> >>> http://www.gwtproject.org/doc/latest/DevGuideCodingBasicsClient.html >>> >>> http://gwtproject.gquery.org/v2/doc/latest/DevGuideCodingBasicsClient.html >>> >>> Can you check if you see them in the same way? or send me a link or >>> screenshot of the page which works wrong? >>> >>> >> I know this is not a regression - as I noted earlier, all of my comments >> on the second part are already existing problems. The code examples was >> broken when we moved to gwtproject.org. >> - We don't have syntax highlighting for example code (you can see that >> in the pages that you have linked) >> - Content is not formatted at all in some sample codes (see >> http://gwtproject.gquery.org/doc/latest/tutorial/JUnit.html#write) - I >> guess I only saw a few of them. >> >> We can defer all these stuff, just pointed in case if they are easy to >> fix. >> >> >>> >>> You can test new changes at http://gwtproject.gquery.org >>> >>> >>> - Manolo >>> >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "GWT Contributors" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] >>> . >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAsipeC_DX-bjA9hstM%2B03QBkd6x6SeztgwOtPswX7xdkw%40mail.gmail.com<https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAM28XAsipeC_DX-bjA9hstM%2B03QBkd6x6SeztgwOtPswX7xdkw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA3qEr%2BQ_DziyHmUASTDk7%3Da4oE%3D02W0cphWYLAVB%3DDjVA%40mail.gmail.com<https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA3qEr%2BQ_DziyHmUASTDk7%3Da4oE%3D02W0cphWYLAVB%3DDjVA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/CABb_3%3D70o8oK3Yw0EYrW4Z2f0BTaxALi5ffnefH4aYh2wQ9vMQ%40mail.gmail.com<https://groups.google.com/d/msgid/google-web-toolkit-contributors/CABb_3%3D70o8oK3Yw0EYrW4Z2f0BTaxALi5ffnefH4aYh2wQ9vMQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA3_QC2iaMhGRA-ROZg8VKrsbhB16-K%3DzjBZnh8oO6hjwg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
