Hi Thomas, Please can you link to the discussion where you decided it was ok to break compatibility with deferred binding implementations of the HistoryImpl.
On Fri, Oct 3, 2014 at 5:15 PM, confile <[email protected]> wrote: > Well if you do not use Places for example when you use GWTP you need the > HistoryImpl to make GWT-pushstate working. > > > > Am Freitag, 3. Oktober 2014 17:11:35 UTC+2 schrieb Thomas Broyer: >> >> >> >> On Friday, October 3, 2014 4:09:33 PM UTC+2, Manuel Carrasco Moñino wrote: >>> >>> >>> >>> On Fri, Oct 3, 2014 at 4:05 PM, confile <[email protected]> >>> wrote: >>> >>>> Well, I need to override HistoryImpl to enable HTML5 pushstate api. >>>> >>> >>> HistoryImpl is now a private class inside History, maybe we could >>> discuss whether to change its visibility. Maybe @Daniel could help here. >>> >> >> When Daniel proposed the change, we decided it was OK to break >> compatibility with, say, Johannes Barop's gwt-pushstate. The rationale was >> that History was explicitly about using the "hash" part of the URL and if >> you wanted something else, or a pluggable implementation, you should use >> another API (Places are pluggable, and you could easily build another API >> similar to History but that would operate differently, whether pluggable or >> not). >> AFAICT the whole discussion is in the review you linked to (or possibly >> another one, as there had been several tries IIRC) >> > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/d3babcef-5e2a-4a2e-a8a2-95a3dd88531f%40googlegroups.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/d3babcef-5e2a-4a2e-a8a2-95a3dd88531f%40googlegroups.com?utm_medium=email&utm_source=footer> > . > > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAEqaEVh9viEQY8mCMoRUt7%2BJLPawFRqdJEtNG9pCiCgP83MH9Q%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
