On 5/5/19 9:51 AM, Willy Tarreau wrote:
On Fri, May 03, 2019 at 07:27:48PM +0200, Frederic Lecaille wrote:
- - env VTEST_PROGRAM=../vtest/vtest make reg-tests
+ - env TMPDIR=~/tmp VTEST_PROGRAM=../vtest/vtest make reg-tests
That may sound like a stupid question, but what makes you think that
~/tmp will actually result in a smaller path ? I mean ~ might very
well be "/home/automated-builds/travis/version-1.2.3.4/haproxy" on
the target system. Thus I think we're trying random locations until
it works :-/
I had no access to any travis environment when it has been told in
previous mails that /tmp could not work, and /var/tmp could not either.
They were the first tested values.
Now that I have setup a travis account, I have just double checked, and
contrary to what has been previously told, /tmp value for TMPDIR may
make the reg tests work on OS X with travis.
So here is attached to this mail a better fix.
Fred.
>From dd2828071bc36375a485a7ab7d6d601d9ce729be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= <flecai...@haproxy.com>
Date: Fri, 3 May 2019 19:16:02 +0200
Subject: [PATCH] BUILD: travis: TMPDIR replacement.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
TMPDIR default value may be too long to create UNIX sockets for the stats
used during the reg tests. Indeed vtest builds its temporary working directory
${tmpdir} variable from TMPDIR variable, with /tmp as value if not already set.
This is the case on Linux contrary to OS X which sets TMPDIR with a too much long
value.
With this path we revert the part of 88c63a6 commit which tried to shorten this
TMPDIR value modifying script/run-regtests.sh. Unfortunately this was not
sufficient. Furthermore this patch force TMPDIR to /tmp value for all the OS'es.
Thank you to Tim Düsterhus and Ilya for having helped on this issue.
---
.travis.yml | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index f689fe982..be3207113 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -27,16 +27,10 @@ install:
# Special flags due to: https://github.com/vtest/VTest/issues/12
- make -C ../vtest FLAGS="-O2 -s -Wall"
-before_script:
- # This is a fix for the super long TMPDIR on Mac making
- # the unix socket path names exceed the maximum allowed
- # length.
- - sed -i'.original' '/TESTDIR=.*haregtests/s/haregtests-.*XXXXXX/regtest.XXX/' scripts/run-regtests.sh
-
script:
- make CC=$CC V=1 TARGET=$TARGET $FLAGS
- ./haproxy -vv
- - env VTEST_PROGRAM=../vtest/vtest make reg-tests
+ - env TMPDIR=/tmp VTEST_PROGRAM=../vtest/vtest make reg-tests
after_failure:
- |
--
2.11.0
