Hi Willy and Ilya, Sorry for the absence, I was mostly out-of-office the last week. I am really sorry for causing this bug. Thanks so much Willy for fixing it as well as for the pool inspection feature I saw today, that looks really handy. I actually debugged the code for quite some time as well, I also tried analyzers but sadly was not able to find it.
While looking through the CI history, I found https://github.com/haproxy/haproxy/runs/16184951880, also related to TLVs and only failing on BSD. I guess, this is actual flakiness then? I didn’t find any related bug fix yet. Best, Alexander From: Илья Шипицин <chipits...@gmail.com> Sent: Thursday, August 31, 2023 8:56 PM To: Willy Tarreau <w...@1wt.eu> Cc: Stephan, Alexander <alexander.step...@sap.com>; haproxy@formilux.org Subject: Re: [PATCH] MEDIUM: sample: Implement sample fetch for arbitrary PROXY protocol v2 TLV values You don't often get email from chipits...@gmail.com<mailto:chipits...@gmail.com>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification> cirrus-ci backtrace freebsd (cirrus-ci) crash · Issue #2275 · haproxy/haproxy (github.com)<https://github.com/haproxy/haproxy/issues/2275> as usual, I'll send CI improvements once polished чт, 31 авг. 2023 г. в 18:22, Илья Шипицин <chipits...@gmail.com<mailto:chipits...@gmail.com>>: while trying to enable "gdb bt" on cirrus-ci, I noticed that we have similar crashes on musl (where gdb implemented already) https://github.com/haproxy/haproxy/issues/2274 ср, 30 авг. 2023 г. в 05:29, Willy Tarreau <w...@1wt.eu<mailto:w...@1wt.eu>>: On Tue, Aug 29, 2023 at 11:16:32PM +0200, ???? ??????? wrote: > ??, 29 ???. 2023 ?. ? 16:45, Willy Tarreau <w...@1wt.eu<mailto:w...@1wt.eu>>: > > > On Tue, Aug 29, 2023 at 04:31:31PM +0200, Willy Tarreau wrote: > > > On Tue, Aug 29, 2023 at 02:16:55PM +0000, Stephan, Alexander wrote: > > > > However, I noticed there is a problem now with the FreeBSD test. Have > > you > > > > already looked into it? > > > > > > Ah no, I had not noticed. I first pushed into a temporary branch and > > > everything was OK so I pushed into master again without checking since > > > it was the exact same commit. > > > > > > > I was not able to reproduce it for now. Looks like the test passes but > > it > > > > crashes afterwards? Maybe some SEGFAULT. Not sure... the CI on your > > branch > > > > looked good iirc. > > > > > > Hmmm no, signal 4 is SIGILL, we're using it for our asserts (BUG_ON()). > > > I never know how to retrieve the stderr log from these tests, there are > > > too many layers for me, I've been explained several times but cannot > > > memorize it. > > > > > > I'm rebuilding here on a freebsd machine, hoping to see it happen again. > > > > > > Note that we cannot rule out a transient issue such as a temporary memory > > > shortage or too long a CPU pause as such VMs are usually overloaded. > > > Maybe it has nothing to do with your new test but just randomly triggered > > > there, or maybe it put the light on a corner case. At least it's not a > > > segfault or such a crash that would indicate a pointer misuse. > > > > I'm getting totally random results from vtest on FreeBSD, I don't know > > why. I even tried to limit to one parallel process and am still getting > > on average 2 errors per run, most always on SSL but not only. Some of > > them include connection failures (sC) with 503 being returned and showing > > "Timeout during SSL handshake". I'm not getting the SIGILL though. Thus > > I don't know what to think about it, especially since it previously worked. > > We'll see if it happens again on next push. > > > > Willy > > > > we can disable cirrus-ci, not sure what is the purpose of randomly failing > CI :) I think it's still used for arm builds or something like this. Regardless, given that freebsd randomly fails on my local platform,there might be something else. I remember that cirrus used to fail some time ago, I don't know what its status is right now. Willy
