> On 2011-11-04 18:26:48, David Capwell wrote: > > Can we have a test added that tests this change?
Do you mean test that the correct outputdirectory is being used? > On 2011-11-04 18:26:48, David Capwell wrote: > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java, > > line 55 > > <https://reviews.apache.org/r/2727/diff/1/?file=56379#file56379line55> > > > > When do we change the output location to match the driver? > > Why not have output storage driver have another init method that gets > > called from HCatOutputformat.setOutput? We are not trying to re-architect the driver interface here. There's already a separate effort for that. We'll update the driver when it comes to that. > On 2011-11-04 18:26:48, David Capwell wrote: > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java, > > line 448 > > <https://reviews.apache.org/r/2727/diff/1/?file=56380#file56380line448> > > > > My MR job should work with RCFiles and with HBase, the output Key > > should be WritableComparible and value should be DefaultHCatRecord This is a different bug which I will address in a separate jira having to do with a bug with SequenceFile and HBaseBulkOutputFormat. - Francis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2727/#review3051 ----------------------------------------------------------- On 2011-11-04 17:44:01, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2727/ > ----------------------------------------------------------- > > (Updated 2011-11-04 17:44:01) > > > Review request for hcatalog, Vandana Ayyalasomayajula and David Capwell. > > > Summary > ------- > > fixed race condition and moved resolution outside of getOutputLocation since > output is intermediate. > > > This addresses bug hcatalog-154. > https://issues.apache.org/jira/browse/hcatalog-154 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java > 989286f > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java > 9dfd238 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java > 19ddd28 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > c25e56d > > Diff: https://reviews.apache.org/r/2727/diff > > > Testing > ------- > > all unit tests pass. > > > Thanks, > > Francis > >
