> On 2011-11-07 17:57:20, Vandana Ayyalasomayajula wrote: > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java, > > line 76 > > <https://reviews.apache.org/r/2727/diff/1/?file=56377#file56377line76> > > > > Hey, can we have some default value for the output revision. Having the > > value to be the current time would break the "montonically increasing" > > revision number assignment we assume for our data.
What value would you suggest? Bear in mind this drop doesn't involve revision management. The default would change once that is in place. - Francis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2727/#review3075 ----------------------------------------------------------- On 2011-11-04 17:44:01, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2727/ > ----------------------------------------------------------- > > (Updated 2011-11-04 17:44:01) > > > Review request for hcatalog, Vandana Ayyalasomayajula and David Capwell. > > > Summary > ------- > > fixed race condition and moved resolution outside of getOutputLocation since > output is intermediate. > > > This addresses bug hcatalog-154. > https://issues.apache.org/jira/browse/hcatalog-154 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java > 989286f > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java > 9dfd238 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java > 19ddd28 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > c25e56d > > Diff: https://reviews.apache.org/r/2727/diff > > > Testing > ------- > > all unit tests pass. > > > Thanks, > > Francis > >
