> On 2011-11-05 01:13:13, David Capwell wrote: > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java, > > line 53 > > <https://reviews.apache.org/r/2727/diff/1/?file=56378#file56378line53> > > > > When would this value be there? The string is private, not in the > > HBaseConstants class so does this mean that users should not be passing > > this in?
yep they shouldn't. - Francis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2727/#review3063 ----------------------------------------------------------- On 2011-11-04 17:44:01, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2727/ > ----------------------------------------------------------- > > (Updated 2011-11-04 17:44:01) > > > Review request for hcatalog, Vandana Ayyalasomayajula and David Capwell. > > > Summary > ------- > > fixed race condition and moved resolution outside of getOutputLocation since > output is intermediate. > > > This addresses bug hcatalog-154. > https://issues.apache.org/jira/browse/hcatalog-154 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java > 989286f > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java > 9dfd238 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java > 19ddd28 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > c25e56d > > Diff: https://reviews.apache.org/r/2727/diff > > > Testing > ------- > > all unit tests pass. > > > Thanks, > > Francis > >
