> On 2011-11-04 18:26:48, David Capwell wrote: > > Can we have a test added that tests this change? > > Francis Liu wrote: > Do you mean test that the correct outputdirectory is being used?
Well, the IOException used to get thrown before, would be nice to have a test that gets the IOException to be thrown before the patch and make sure it passes after, and another test that tries to get the new IOException to be thrown (even though it shouldn't) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2727/#review3051 ----------------------------------------------------------- On 2011-11-04 17:44:01, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2727/ > ----------------------------------------------------------- > > (Updated 2011-11-04 17:44:01) > > > Review request for hcatalog, Vandana Ayyalasomayajula and David Capwell. > > > Summary > ------- > > fixed race condition and moved resolution outside of getOutputLocation since > output is intermediate. > > > This addresses bug hcatalog-154. > https://issues.apache.org/jira/browse/hcatalog-154 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java > 989286f > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java > 9dfd238 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java > 19ddd28 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > c25e56d > > Diff: https://reviews.apache.org/r/2727/diff > > > Testing > ------- > > all unit tests pass. > > > Thanks, > > Francis > >
