----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2727/#review3171 -----------------------------------------------------------
Ship it! Looks good - David On 2011-11-10 00:14:03, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2727/ > ----------------------------------------------------------- > > (Updated 2011-11-10 00:14:03) > > > Review request for hcatalog, Sushanth Sowmyan, Vandana Ayyalasomayajula, and > David Capwell. > > > Summary > ------- > > fixed race condition and moved resolution outside of getOutputLocation since > output is intermediate. > > > This addresses bug hcatalog-154. > https://issues.apache.org/jira/browse/hcatalog-154 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java > 989286f > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java > e251ce9 > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java > 25639d2 > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > c25e56d > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseOutputStorageDriver.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/2727/diff > > > Testing > ------- > > all unit tests pass. > > > Thanks, > > Francis > >
