----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4623/#review6659 -----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/common/HCatConstants.java <https://reviews.apache.org/r/4623/#comment14377> Nitpick. Some other name instead of CALLED would be better. LOCATION_SET or something that is more related. /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java <https://reviews.apache.org/r/4623/#comment14379> We should be putting all configs. Not only ones that start with HCAT_KEY_BASE. Need to add credentials if it is not backend. We will have to store credentials in UDFContext properties but remove it before the job is submitted so that it is not part of the Configuration and appears in the UI. /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java <https://reviews.apache.org/r/4623/#comment14380> You can directly use for statement without having to use iterator. /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java <https://reviews.apache.org/r/4623/#comment14385> Need to do null check and .equals instead of != /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java <https://reviews.apache.org/r/4623/#comment14386> Need to set all config and also credentials if not backend. - Rohini On 2012-04-03 18:43:12, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4623/ > ----------------------------------------------------------- > > (Updated 2012-04-03 18:43:12) > > > Review request for hcatalog, Francis Liu and Rohini Palaniswamy. > > > Summary > ------- > > HCatStorer.setStoreLocation() is called more than once by pig. Which ends up > calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput > should be called only once, the values that it changed must be tracked and > reapplied to job.getconfiguration() the succeeding times it is called. > HCatLoader may have the same issue and should be investigated as well. > > > This addresses bug hcatalog-314. > https://issues.apache.org/jira/browse/hcatalog-314 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1309001 > /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1309001 > /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1309001 > > Diff: https://reviews.apache.org/r/4623/diff > > > Testing > ------- > > The trunk builds are currently failing. I will run the entire test suite once > the build is fine. > > > Thanks, > > Vandana > >
