----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4623/#review6719 -----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/common/HCatConstants.java <https://reviews.apache.org/r/4623/#comment14551> Probably is unused and can be removed. /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java <https://reviews.apache.org/r/4623/#comment14550> We will need credentials in HCatLoader also if setLocation is called multiple times on it. /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java <https://reviews.apache.org/r/4623/#comment14549> This will cause memory leak. A WeakHashMap perhaps? /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java <https://reviews.apache.org/r/4623/#comment14548> credentials will be null when the code is called from the backend. - Rohini On 2012-04-05 21:25:15, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4623/ > ----------------------------------------------------------- > > (Updated 2012-04-05 21:25:15) > > > Review request for hcatalog, Francis Liu and Rohini Palaniswamy. > > > Summary > ------- > > HCatStorer.setStoreLocation() is called more than once by pig. Which ends up > calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput > should be called only once, the values that it changed must be tracked and > reapplied to job.getconfiguration() the succeeding times it is called. > HCatLoader may have the same issue and should be investigated as well. > > > This addresses bug hcatalog-314. > https://issues.apache.org/jira/browse/hcatalog-314 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1309184 > /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1309184 > /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1309184 > > Diff: https://reviews.apache.org/r/4623/diff > > > Testing > ------- > > Trunk build + tests pass. > > > Thanks, > > Vandana > >
