-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4623/
-----------------------------------------------------------

(Updated 2012-04-03 21:31:04.777461)


Review request for hcatalog, Francis Liu and Rohini Palaniswamy.


Changes
-------

- Added code to store job credentials in udf properties on store side. 
- modified code to copy all the properties from udf context to job config. 


Summary
-------

HCatStorer.setStoreLocation() is called more than once by pig. Which ends up 
calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput 
should be called only once, the values that it changed must be tracked and 
reapplied to job.getconfiguration() the succeeding times it is called. 
HCatLoader may have the same issue and should be investigated as well.


This addresses bug hcatalog-314.
    https://issues.apache.org/jira/browse/hcatalog-314


Diffs (updated)
-----

  /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1309001 
  /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1309001 
  /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1309001 

Diff: https://reviews.apache.org/r/4623/diff


Testing
-------

The trunk builds are currently failing. I will run the entire test suite once 
the build is fine.


Thanks,

Vandana

Reply via email to