-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4623/
-----------------------------------------------------------
(Updated 2012-04-06 16:26:55.683133)
Review request for hcatalog, Francis Liu and Rohini Palaniswamy.
Changes
-------
- Addressed Rohini's comments.
- Ran the E2E tests ( Thanks to Thomas for lending his set up ).
- All the build, unit tests, E2E test pass.
Summary
-------
HCatStorer.setStoreLocation() is called more than once by pig. Which ends up
calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput
should be called only once, the values that it changed must be tracked and
reapplied to job.getconfiguration() the succeeding times it is called.
HCatLoader may have the same issue and should be investigated as well.
This addresses bug hcatalog-314.
https://issues.apache.org/jira/browse/hcatalog-314
Diffs (updated)
-----
/trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1309184
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1309184
/trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1309184
Diff: https://reviews.apache.org/r/4623/diff
Testing
-------
Trunk build + tests pass.
Thanks,
Vandana
