----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4623/#review6916 -----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java <https://reviews.apache.org/r/4623/#comment15381> We shouldn't use weakhashmap here. else we might lose delegation tokens since you're not keeping a reference to the key. /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java <https://reviews.apache.org/r/4623/#comment15386> don't run this if running in the backend. else if(!runningFromBackEnd){} else {throw IllegalStateException())} /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java <https://reviews.apache.org/r/4623/#comment15391> same concerns with loader class. usage of weakhashmap and else if, else statement. - Francis On 2012-04-10 22:13:03, Vandana Ayyalasomayajula wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4623/ > ----------------------------------------------------------- > > (Updated 2012-04-10 22:13:03) > > > Review request for hcatalog, Francis Liu, Thomas, and Rohini Palaniswamy. > > > Summary > ------- > > HCatStorer.setStoreLocation() is called more than once by pig. Which ends up > calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput > should be called only once, the values that it changed must be tracked and > reapplied to job.getconfiguration() the succeeding times it is called. > HCatLoader may have the same issue and should be investigated as well. > > > This addresses bug hcatalog-314. > https://issues.apache.org/jira/browse/hcatalog-314 > > > Diffs > ----- > > /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1312006 > /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1312006 > /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1312006 > > Diff: https://reviews.apache.org/r/4623/diff > > > Testing > ------- > > Trunk build + tests pass. > > > Thanks, > > Vandana > >
