-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4623/
-----------------------------------------------------------

(Updated 2012-04-09 16:08:59.141179)


Review request for hcatalog, Francis Liu, Thomas, and Rohini Palaniswamy.


Changes
-------

- Added additional comments for the hash map storing job credentials. 


Summary
-------

HCatStorer.setStoreLocation() is called more than once by pig. Which ends up 
calling HCatOutputFormat.setOutput multiple times. HCatOutputFormat.setOutput 
should be called only once, the values that it changed must be tracked and 
reapplied to job.getconfiguration() the succeeding times it is called. 
HCatLoader may have the same issue and should be investigated as well.


This addresses bug hcatalog-314.
    https://issues.apache.org/jira/browse/hcatalog-314


Diffs (updated)
-----

  /trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1309184 
  /trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1309184 
  /trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1309184 

Diff: https://reviews.apache.org/r/4623/diff


Testing
-------

Trunk build + tests pass. 


Thanks,

Vandana

Reply via email to