[
https://issues.apache.org/jira/browse/HCATALOG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263186#comment-13263186
]
[email protected] commented on HCATALOG-68:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4732/#review7285
-----------------------------------------------------------
/trunk/src/java/org/apache/hcatalog/common/HCatUtil.java
<https://reviews.apache.org/r/4732/#comment16079>
I see this piece of code all over the place, where we instantiate
LoggerFactory.getLogger with the class name that's instantiating the Logger.
It's good that each logger is class-zoned, but I'm not too happy about needing
to call it with that class name in each class.
In the past, this has caused issues when we've copy-pasted code to another
class, for example, and not noticed that the class name of the logger needed to
be changed. So one suggestion I'd have is to make a util method called
getLogger() or somesuch which instantiates the Logger. I understand that the
problem with that is that everything will seem to have come from the class that
contained getLogger, but that is easily solved by having it do the following :
Create a new exception, and go 1 step up the stack trace. Find the class name
associated with that, and that's your calling class. Now use that class to
instantiate the logger, and return.
- Sushanth
On 2012-04-26 21:31:21, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4732/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-26 21:31:21)
bq.
bq.
bq. Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. We need to do the following things:
bq.
bq. + Use log4j across the board
bq. + Introduce a class with methods to help logging, refactoring away the
bunch of these functions in HCatUtil right now
bq. + Instrument debug logging with isLogEnabled checks on the log level
bq. + remove all instances of commented code whose purpose was for debug logs
bq.
bq.
bq. This addresses bug hcatalog-68.
bq. https://issues.apache.org/jira/browse/hcatalog-68
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/ivy.xml 1331003
bq.
/trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
1331003
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1331003
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1331003
bq.
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
1331003
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1331003
bq. /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1331003
bq.
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1331003
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
1331003
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1331003
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1331003
bq. /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1331003
bq. /trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1331003
bq.
bq. Diff: https://reviews.apache.org/r/4732/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass. Log messages verified from test logs.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> Logging from HCat
> -----------------
>
> Key: HCATALOG-68
> URL: https://issues.apache.org/jira/browse/HCATALOG-68
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Sushanth Sowmyan
> Assignee: Vandana Ayyalasomayajula
>
> We need to do the following things:
> + Use log4j across the board
> + Introduce a class with methods to help logging, refactoring away the
> bunch of these functions in HCatUtil right now
> + Instrument debug logging with isLogEnabled checks on the log level
> + remove all instances of commented code whose purpose was for debug logs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
