[
https://issues.apache.org/jira/browse/HCATALOG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263315#comment-13263315
]
[email protected] commented on HCATALOG-68:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4732/
-----------------------------------------------------------
(Updated 2012-04-27 02:57:41.504169)
Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas.
Changes
-------
-- Replaced all the System.out and System.err messages in the various test
cases with appropriate log messages.
Summary
-------
We need to do the following things:
+ Use log4j across the board
+ Introduce a class with methods to help logging, refactoring away the bunch of
these functions in HCatUtil right now
+ Instrument debug logging with isLogEnabled checks on the log level
+ remove all instances of commented code whose purpose was for debug logs
This addresses bug hcatalog-68.
https://issues.apache.org/jira/browse/hcatalog-68
Diffs (updated)
-----
/trunk/ivy.xml 1331188
/trunk/src/java/org/apache/hcatalog/cli/HCatCli.java 1331188
/trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
1331188
/trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1331188
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1331188
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
1331188
/trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1331188
/trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1331188
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1331188
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java 1331188
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1331188
/trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1331188
/trunk/src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java 1331188
/trunk/src/test/org/apache/hcatalog/cli/TestPermsGrp.java 1331188
/trunk/src/test/org/apache/hcatalog/cli/TestSemanticAnalysis.java 1331188
/trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1331188
/trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java 1331188
/trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1331188
/trunk/src/test/org/apache/hcatalog/data/schema/TestHCatSchemaUtils.java
1331188
/trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java 1331188
/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java
1331188
/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java
1331188
/trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java
1331188
/trunk/src/test/org/apache/hcatalog/rcfile/TestRCFileMapReduceInputFormat.java
1331188
Diff: https://reviews.apache.org/r/4732/diff
Testing
-------
Unit tests pass. Log messages verified from test logs.
Thanks,
Vandana
> Logging from HCat
> -----------------
>
> Key: HCATALOG-68
> URL: https://issues.apache.org/jira/browse/HCATALOG-68
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Sushanth Sowmyan
> Assignee: Vandana Ayyalasomayajula
>
> We need to do the following things:
> + Use log4j across the board
> + Introduce a class with methods to help logging, refactoring away the
> bunch of these functions in HCatUtil right now
> + Instrument debug logging with isLogEnabled checks on the log level
> + remove all instances of commented code whose purpose was for debug logs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
