[
https://issues.apache.org/jira/browse/HCATALOG-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265184#comment-13265184
]
[email protected] commented on HCATALOG-68:
-------------------------------------------------------
bq. On 2012-04-27 21:07:48, David Capwell wrote:
bq. > /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java, lines 153-156
bq. >
<https://reviews.apache.org/r/4732/diff/9-10/?file=104702#file104702line153>
bq. >
bq. > Why was this revered back? patch 9 was using the throwable
interface, this one reverts back to the old one using Object, Object
bq.
bq. Vandana Ayyalasomayajula wrote:
bq. The original source had the text causing the exception also logged.
The previous patch had only the exception being logged. Sushant pointed out
that this was resulting in reduced info on the log. I think this is okay as the
exception is again thrown.
So Vandana and I looked and this should be very descriptive saying the
line/column number for where json failed and the json string itself. This
should be enough information from the user's point of view.
bq. On 2012-04-27 21:07:48, David Capwell wrote:
bq. > /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java, lines
84-86
bq. >
<https://reviews.apache.org/r/4732/diff/9-10/?file=104707#file104707line84>
bq. >
bq. > It might be best to wrap this around an ifInfo check since its going
to loop. I would assume info would be enabled more often then not so might not
be needed.
bq.
bq. Vandana Ayyalasomayajula wrote:
bq. I think we don't need the loop at all taking a closer look. Its a list
of string.
Even better!
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4732/#review7323
-----------------------------------------------------------
On 2012-04-27 02:57:41, Vandana Ayyalasomayajula wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4732/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-27 02:57:41)
bq.
bq.
bq. Review request for hcatalog, Sushanth Sowmyan, Francis Liu, and Thomas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. We need to do the following things:
bq.
bq. + Use log4j across the board
bq. + Introduce a class with methods to help logging, refactoring away the
bunch of these functions in HCatUtil right now
bq. + Instrument debug logging with isLogEnabled checks on the log level
bq. + remove all instances of commented code whose purpose was for debug logs
bq.
bq.
bq. This addresses bug hcatalog-68.
bq. https://issues.apache.org/jira/browse/hcatalog-68
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/ivy.xml 1331188
bq. /trunk/src/java/org/apache/hcatalog/cli/HCatCli.java 1331188
bq.
/trunk/src/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
1331188
bq. /trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1331188
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspector.java
1331188
bq.
/trunk/src/java/org/apache/hcatalog/data/HCatRecordObjectInspectorFactory.java
1331188
bq. /trunk/src/java/org/apache/hcatalog/data/HCatRecordSerDe.java 1331188
bq. /trunk/src/java/org/apache/hcatalog/data/JsonSerDe.java 1331188
bq.
/trunk/src/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
1331188
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordReader.java
1331188
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/HCatSplit.java 1331188
bq. /trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java
1331188
bq. /trunk/src/test/org/apache/hcatalog/cli/TestEximSemanticAnalysis.java
1331188
bq. /trunk/src/test/org/apache/hcatalog/cli/TestPermsGrp.java 1331188
bq. /trunk/src/test/org/apache/hcatalog/cli/TestSemanticAnalysis.java
1331188
bq. /trunk/src/test/org/apache/hcatalog/data/HCatDataCheckUtil.java 1331188
bq. /trunk/src/test/org/apache/hcatalog/data/TestHCatRecordSerDe.java
1331188
bq. /trunk/src/test/org/apache/hcatalog/data/TestJsonSerDe.java 1331188
bq. /trunk/src/test/org/apache/hcatalog/data/schema/TestHCatSchemaUtils.java
1331188
bq. /trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java
1331188
bq.
/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java
1331188
bq. /trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java
1331188
bq. /trunk/src/test/org/apache/hcatalog/pig/TestHCatLoaderComplexSchema.java
1331188
bq.
/trunk/src/test/org/apache/hcatalog/rcfile/TestRCFileMapReduceInputFormat.java
1331188
bq.
bq. Diff: https://reviews.apache.org/r/4732/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass. Log messages verified from test logs.
bq.
bq.
bq. Thanks,
bq.
bq. Vandana
bq.
bq.
> Logging from HCat
> -----------------
>
> Key: HCATALOG-68
> URL: https://issues.apache.org/jira/browse/HCATALOG-68
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Sushanth Sowmyan
> Assignee: Vandana Ayyalasomayajula
>
> We need to do the following things:
> + Use log4j across the board
> + Introduce a class with methods to help logging, refactoring away the
> bunch of these functions in HCatUtil right now
> + Instrument debug logging with isLogEnabled checks on the log level
> + remove all instances of commented code whose purpose was for debug logs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
